Skip to content

Conversation

@JoerivanEngelen
Copy link
Contributor

@JoerivanEngelen JoerivanEngelen commented Dec 18, 2025

Fixes #1743, #1746 and #1747

Description

Fixes the following problems to the Modflow6Simulation.clip_box :

  • A mistake in the template ConstantConcentration package, which makes it unable to write transient packages
  • Enforce dimension order before creating the clipped boundary package, as ValidationErrors could be thrown when the model already contained a ConstantConcentration or ConstantHead package.
  • Align layers with an outer align to prevent layers being dropped when ConstantConcentration or ConstantHead was assigned to less layers.
  • Reindex timesteps with a forward fill to properly filter out cells present in ConstantConcentration or ConstantHead packages with different time domains.

Furthermore a bit of maintenance:

  • Declutter tests a bit
  • Add some missing type annotations for return types and fix mypy errors

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example
  • If feature added: Added feature to API documentation
  • If pixi.lock was changed: Ran pixi run generate-sbom and committed changes

@JoerivanEngelen JoerivanEngelen marked this pull request as ready for review December 19, 2025 17:00
@JoerivanEngelen JoerivanEngelen changed the title Issue #1743 fix transient clip box Issue #1743 fix clip_box with transient states_at_boundary Dec 19, 2025
- Fixed bug where :class:`imod.mf6.Evapotranspiration` package would write files
to binary, which could not be parsed by MODFLOW 6 when ``proportion_depth``
and ``proportion_rate`` were provided without segments.
- Bug where :class:`imod.mf6.ConstantConcentration` package could not be written
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add Fix before each of the bullet points

@JoerivanEngelen JoerivanEngelen merged commit 25987f9 into master Jan 6, 2026
@JoerivanEngelen JoerivanEngelen deleted the issue_#1743_fix_transient_clip_box branch January 6, 2026 14:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants