-
Notifications
You must be signed in to change notification settings - Fork 6
Issue #1743 fix clip_box with transient states_at_boundary
#1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+313
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clip_box with transient states_at_boundary
This was
linked to
issues
Dec 19, 2025
…e_period_data writes the right amount of data
Manangka
approved these changes
Jan 6, 2026
docs/api/changelog.rst
Outdated
| - Fixed bug where :class:`imod.mf6.Evapotranspiration` package would write files | ||
| to binary, which could not be parsed by MODFLOW 6 when ``proportion_depth`` | ||
| and ``proportion_rate`` were provided without segments. | ||
| - Bug where :class:`imod.mf6.ConstantConcentration` package could not be written |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add Fix before each of the bullet points
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Fixes #1743, #1746 and #1747
Description
Fixes the following problems to the
Modflow6Simulation.clip_box:ConstantConcentrationpackage, which makes it unable to write transient packagesConstantConcentrationorConstantHeadpackage.ConstantConcentrationorConstantHeadwas assigned to less layers.ConstantConcentrationorConstantHeadpackages with different time domains.Furthermore a bit of maintenance:
Checklist
Issue #nr, e.g.Issue #737pixi run generate-sbomand committed changes